sunhelly commented on code in PR #4788:
URL: https://github.com/apache/hbase/pull/4788#discussion_r1096908379


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -2420,8 +2431,6 @@ private void startActiveMasterManager(int infoPort) 
throws KeeperException {
       } else {
         abort("Unhandled exception. Starting shutdown.", t);
       }
-    } finally {
-      status.cleanup();

Review Comment:
   If "hbase.master.ignore.clear.startup.status" is off(default on), when 
master startup successfully, all the steps info base by the phased monitored 
tasks will be cleared. This means we can see the starup progress during the 
master becoming active, but after active the phased tasks is cleared, we can 
see nothing about the startup progress then through the UI.
   We remove this config then the startup phased monitored tasks are kept in 
the memory, then whenever open the starup UI, the detailed phased info is 
showed. This makes the destination of the issue more clear, and is definitely  
different to the previous startup monitor task.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to