thangTang commented on PR #5012: URL: https://github.com/apache/hbase/pull/5012#issuecomment-1420537697
I know this kind of implementation is ugly, we'd better let these metrics be automatically eliminated as the table/region moves. But after reading the relevant code, I feel that it is really confusing. For example in [MetricsRegionServer](https://github.com/apache/hbase/blob/198a3b7e891b67468748abe2968975148d96632f/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java#L98) We have a `tableMetrics`, and a `metricsTable`, they have completely different encapsulations and implementations, it is really hard to understand... So I chose this clumsy but simple way to solve the problem quickly, after that we should do some refactoring of tableMetrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
