[
https://issues.apache.org/jira/browse/HBASE-27617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685203#comment-17685203
]
tianhang tang edited comment on HBASE-27617 at 2/7/23 10:26 AM:
----------------------------------------------------------------
I know this kind of implementation is ugly, we'd better let these metrics be
automatically eliminated as the table/region moves.
But after reading the relevant code, I feel that it is really confusing. For
example in
[MetricsRegionServer|https://github.com/apache/hbase/blob/198a3b7e891b67468748abe2968975148d96632f/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java#L98]
We have a
{code:java}
tableMetrics
{code}
, and a
{code:java}
metricsTable
{code}
, they have completely different encapsulations and implementations, it is
really hard to understand...
So I chose this clumsy but simple way to solve the problem quickly, after that
we should do some refactoring of tableMetrics.
was (Author: tangtianhang):
I know this kind of implementation is ugly, we'd better let these metrics be
automatically eliminated as the table/region moves.
But after reading the relevant code, I feel that it is really confusing. For
example in
[MetricsRegionServer|https://github.com/apache/hbase/blob/198a3b7e891b67468748abe2968975148d96632f/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java#L98]
We have a tableMetrics, and a metricsTable, they have completely different
encapsulations and implementations, it is really hard to understand...
So I chose this clumsy but simple way to solve the problem quickly, after that
we should do some refactoring of tableMetrics.
> Make metrics from MetricsTableLatenciesImpl removable
> -----------------------------------------------------
>
> Key: HBASE-27617
> URL: https://issues.apache.org/jira/browse/HBASE-27617
> Project: HBase
> Issue Type: Bug
> Reporter: tianhang tang
> Assignee: tianhang tang
> Priority: Major
>
> Now the table latency metrics will last forever on a RS.
> Could reproduce this issue easily:
> 1. Create a test table and the region opened on RS_A;
> 2. Do a query;
> 3. Move the table to another group;
> 4. See JMX on RS_A, table latency metrics still exists and will not deleted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
