Apache9 commented on code in PR #4995:
URL: https://github.com/apache/hbase/pull/4995#discussion_r1099616743
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotHFileCleaner.java:
##########
@@ -64,8 +67,10 @@ public class SnapshotHFileCleaner extends
BaseHFileCleanerDelegate {
@Override
public Iterable<FileStatus> getDeletableFiles(Iterable<FileStatus> files) {
+ List<FileStatus> filesList =
Review Comment:
Better add some comments here to say why we want a List instead of a
Iterable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
