Apache9 commented on code in PR #5016:
URL: https://github.com/apache/hbase/pull/5016#discussion_r1100301910
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/TagCompressionContext.java:
##########
@@ -107,15 +107,15 @@ public void uncompressTags(InputStream src, byte[] dest,
int offset, int length)
throws IOException {
int endOffset = offset + length;
while (offset < endOffset) {
- byte status = (byte) src.read();
+ byte status = StreamUtils.readByte(src);
if (status == Dictionary.NOT_IN_DICTIONARY) {
int tagLen = StreamUtils.readRawVarint32(src);
offset = Bytes.putAsShort(dest, offset, tagLen);
IOUtils.readFully(src, dest, offset, tagLen);
- tagDict.addEntry(dest, offset, tagLen);
+ tagDict.findEntry(dest, offset, tagLen);
Review Comment:
It is slower than before but I always think correctness comes first, and
then we consider the performance. For log splitting and replication, reading is
usually not the bottleneck.
Can file an follow on issue to do the optimization, maybe we could add a
reset flag in CompressionContext too, to indicate that whether we need to do a
lookup first.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
