apurtell commented on code in PR #5023: URL: https://github.com/apache/hbase/pull/5023#discussion_r1106086905
########## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ########## @@ -118,6 +120,9 @@ static String getScope(Configuration conf, String clusterId, Object connectionOb private static final String CNT_BASE = "rpcCount_"; private static final String FAILURE_CNT_BASE = "rpcFailureCount_"; + private static final String TIMEOUT_CNT_BASE = "rpcExceptionCallTimeout_"; + private static final String REMOTE_CNT_BASE = "rpcExceptionRemote_"; + private static final String OTHERS_CNT_BASE = "rpcExceptionOthers_"; Review Comment: As an operator seeing this metric for the first time I would immediately wonder what "other" means. Can this be defined as something more definitive? "other" can mean anything. ########## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ########## @@ -118,6 +120,9 @@ static String getScope(Configuration conf, String clusterId, Object connectionOb private static final String CNT_BASE = "rpcCount_"; private static final String FAILURE_CNT_BASE = "rpcFailureCount_"; + private static final String TIMEOUT_CNT_BASE = "rpcExceptionCallTimeout_"; + private static final String REMOTE_CNT_BASE = "rpcExceptionRemote_"; Review Comment: A remote exception can be caused by many things. Should this be more granular? At least consider differentiating between non retryable DoNotRetryIOExceptions and the other retryable IOExceptions. So that would be two counters here for remote. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
