virajjasani commented on code in PR #5032:
URL: https://github.com/apache/hbase/pull/5032#discussion_r1113872723
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java:
##########
@@ -410,8 +410,7 @@ protected boolean readNext(Entry entry) throws IOException {
if (!walKey.hasFollowingKvCount() || 0 == walKey.getFollowingKvCount()) {
LOG.trace("WALKey has no KVs that follow it; trying the next one.
current offset={}",
this.inputStream.getPos());
Review Comment:
Wow, that's a big one. When I saw dataloss explanation, I wanted to check
for logs `WALKey has no KVs that follow it; trying the next one.` to see how
many, if at all num of such references we see but then realized it is at TRACE
level. Shall we make it at least DEBUG level?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java:
##########
@@ -410,8 +410,7 @@ protected boolean readNext(Entry entry) throws IOException {
if (!walKey.hasFollowingKvCount() || 0 == walKey.getFollowingKvCount()) {
LOG.trace("WALKey has no KVs that follow it; trying the next one.
current offset={}",
this.inputStream.getPos());
- seekOnFs(originalPosition);
- return false;
+ return true;
Review Comment:
For the core change, I wonder if it might still be possible to have
replication delays with specific encryption as explained on HBASE-20604.
(though possible dataloss during WAL splitting is definitely much serious
case to consider)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
