hgromer commented on code in PR #5051:
URL: https://github.com/apache/hbase/pull/5051#discussion_r1119389359


##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestVerifyReplication.java:
##########
@@ -447,6 +447,36 @@ public void 
testVerifyRepJobWithPeerTableNameAndSnapshotSupport() throws Excepti
     checkRestoreTmpDir(CONF2, tmpPath2, 2);
   }
 
+  @Test
+  public void testVerifyReplicationThreadedRecompares() throws Exception {

Review Comment:
   The idea here is that the default behavior represents VR the way it 
currently exists. Constant sleep time, 1 recompare, singly threaded. By 
creating a VR run that's threaded, and with reCompareTries > 1, we test out the 
asynchronous comparisons and make sure that the job produces the counters we're 
expecting.
   
   That being said, we don't actually check that the recompares have been 
executed `Counters.RE_COMPARES`, which might be a good thing to check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to