Apache9 commented on code in PR #5036:
URL: https://github.com/apache/hbase/pull/5036#discussion_r1119534251
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java:
##########
@@ -71,30 +71,41 @@ public <T> RpcRetryingCaller<T> newCaller() {
interceptor, startLogErrorsCnt, connectionConf.getRpcTimeout(), metrics);
}
- public static RpcRetryingCallerFactory instantiate(Configuration
configuration,
+ @RestrictedApi(explanation = "Should only be called on process
initialization", link = "",
+ allowedOnPath =
".*/hbase-server/src/main/java/.*/(HRegionServer|LoadIncrementalHFiles|SecureBulkLoadClient)\\.java")
+ public static RpcRetryingCallerFactory instantiate(Configuration
configuration, MetricsConnection metrics) {
+ return instantiate(configuration, new
ConnectionConfiguration(configuration), metrics);
+ }
+
+ public static RpcRetryingCallerFactory instantiate(Configuration
configuration, ConnectionConfiguration connectionConf,
MetricsConnection metrics) {
- return instantiate(configuration,
RetryingCallerInterceptorFactory.NO_OP_INTERCEPTOR, null,
+ return instantiate(configuration, connectionConf,
RetryingCallerInterceptorFactory.NO_OP_INTERCEPTOR, null,
metrics);
}
- public static RpcRetryingCallerFactory instantiate(Configuration
configuration,
+ public static RpcRetryingCallerFactory instantiate(Configuration
configuration, ConnectionConfiguration connectionConf,
ServerStatisticTracker stats, MetricsConnection metrics) {
- return instantiate(configuration,
RetryingCallerInterceptorFactory.NO_OP_INTERCEPTOR, stats,
+ return instantiate(configuration, connectionConf,
RetryingCallerInterceptorFactory.NO_OP_INTERCEPTOR, stats,
metrics);
}
- public static RpcRetryingCallerFactory instantiate(Configuration
configuration,
+ public static RpcRetryingCallerFactory instantiate(Configuration
configuration, ConnectionConfiguration connectionConf,
RetryingCallerInterceptor interceptor, ServerStatisticTracker stats,
MetricsConnection metrics) {
String clazzName = RpcRetryingCallerFactory.class.getName();
String rpcCallerFactoryClazz =
configuration.get(RpcRetryingCallerFactory.CUSTOM_CALLER_CONF_KEY,
clazzName);
RpcRetryingCallerFactory factory;
if (rpcCallerFactoryClazz.equals(clazzName)) {
Review Comment:
I suppose we only want to use this in tests? Not for users...
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java:
##########
@@ -17,32 +17,32 @@
*/
package org.apache.hadoop.hbase.client;
+import com.google.errorprone.annotations.RestrictedApi;
import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
import org.apache.hadoop.hbase.util.ReflectionUtils;
import org.apache.yetus.audience.InterfaceAudience;
/**
* Factory to create an {@link RpcRetryingCaller}
*/
[email protected]
[email protected](HBaseInterfaceAudience.CONFIG)
Review Comment:
Really? There is no interface, how could we provide different
implementations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
