bbeaudreault commented on code in PR #5063:
URL: https://github.com/apache/hbase/pull/5063#discussion_r1124801564
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java:
##########
@@ -269,6 +269,7 @@ private FSDataInputStream tryOpen() throws IOException {
}
}
currentPath = path;
+ fileLink.setReaderPath(path);
Review Comment:
I think it's odd that doing `new FileLinkInputStream(fs, fileLink)` modifies
my passed in FileLink.
Maybe not the end of the world, but seems better to keep immutable. Is there
any other way to do what you're trying to do without mutating the passed in
link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
