bbeaudreault commented on code in PR #5072:
URL: https://github.com/apache/hbase/pull/5072#discussion_r1125500348
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -373,6 +375,15 @@ public void setRestoredRegion(boolean restoredRegion) {
isRestoredRegion = restoredRegion;
}
+ // Handle table latency metrics
+ private MetricsTableRequests metricsTableRequests;
+
+ public void ifTableRequestsMetricsExist(Consumer<MetricsTableRequests>
consumer) {
Review Comment:
sorry i wasn't clear... i was wrong here, and I dont think this method
actually improves much. can we revert this part too? sorry
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -4690,9 +4710,10 @@ private OperationStatus[] batchMutate(BatchOperation<?>
batchOp) throws IOExcept
requestFlushIfNeeded();
}
} finally {
- if (rsServices != null && rsServices.getMetrics() != null) {
Review Comment:
can we revert this diff back to `if (this.rsServices != null &&
this.rsServices.getMetrics() != null)`? same below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
