[ 
https://issues.apache.org/jira/browse/HBASE-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408330#comment-13408330
 ] 

Matteo Bertozzi commented on HBASE-6205:
----------------------------------------

Do we really need almost 3 + 1 identical features?
 * backup mode (HBASE-5547)
 * snapshots (HBASE-6055)
 * keep data for some time before delete (HBASE-6205)
 * HDFS trash (why is shell only?)

Can't we just do everything with the snapshots? maybe marking the snapshot with 
some tag like User-Snapshot, Backup-Snapshot, Delete-Snapshot?
The table backup can be done by taking a snapshot end exporting it to another 
cluster.
The delete can create a snapshot and you should be able to restore it.

Maybe we can have some properties to say:
 * hbase.droptable.snapshot (true|false) take an automatic snapshot on drop 
table
 * hbase.droptable.snapshot.lifetime (sec) keep the drop table snapshot for X 
seconds.
                
> Support an option to keep data of dropped table for some time
> -------------------------------------------------------------
>
>                 Key: HBASE-6205
>                 URL: https://issues.apache.org/jira/browse/HBASE-6205
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6205.patch, HBASE-6205v2.patch, 
> HBASE-6205v3.patch, HBASE-6205v4.patch, HBASE-6205v5.patch
>
>
> User may drop table accidentally because of error code or other uncertain 
> reasons.
> Unfortunately, it happens in our environment because one user make a mistake 
> between production cluster and testing cluster.
> So, I just give a suggestion, do we need to support an option to keep data of 
> dropped table for some time, e.g. 1 day
> In the patch:
> We make a new dir named .trashtables in the rood dir.
> In the DeleteTableHandler, we move files in dropped table's dir to trash 
> table dir instead of deleting them directly.
> And Create new class TrashCleaner which will clean dropped tables if it is 
> time out with a period check.
> Default keep time for dropped tables is 1 day, and check period is 1 hour.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to