shahrs87 commented on code in PR #5081:
URL: https://github.com/apache/hbase/pull/5081#discussion_r1129888359


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java:
##########
@@ -1125,10 +1130,21 @@ rpcControllerFactory, getMetaLookupPool(), 
connectionConfig.getMetaReadRpcTimeou
 
   void takeUserRegionLock() throws IOException {
     try {
+      long waitStartTime = 0;

Review Comment:
   Is there any reason to assign waitStartTime to 0 here  and then assign it to 
`EnvironmentEdgeManager.currentTime()` within if condition? Can we assign to 
`EnvironmentEdgeManager.currentTime()` directly. The updating of 
`updateUserRegionLockWaiting` metric is already safeguarded within if conditon.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to