d-c-manning commented on code in PR #5081:
URL: https://github.com/apache/hbase/pull/5081#discussion_r1130027275
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java:
##########
@@ -1125,10 +1130,21 @@ rpcControllerFactory, getMetaLookupPool(),
connectionConfig.getMetaReadRpcTimeou
void takeUserRegionLock() throws IOException {
try {
+ long waitStartTime = 0;
long waitTime = connectionConfig.getMetaOperationTimeout();
+ if (metrics != null) {
Review Comment:
I have no strong opinion. Clearly what @shahrs87 says makes sense, and is an
improvement. But it can also be considered to be outside of the scope of this
PR, as the pattern exists elsewhere in this file already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
