Apache9 commented on code in PR #5100:
URL: https://github.com/apache/hbase/pull/5100#discussion_r1138253165
##########
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java:
##########
@@ -73,15 +73,14 @@ public interface MetricsRegionSource extends
Comparable<MetricsRegionSource> {
void updateDelete();
/**
- * Update time of gets
- * @param mills time for this get operation.
+ * Update related counts of gets
*/
- void updateGet(long mills);
+ void updateGet();
/**
- * Update time used of resultScanner.next().
+ * Update related counts of resultScanner.next().
*/
- void updateScanTime(long mills);
+ void updateScanCount();
Review Comment:
Why not call it updateScan? We do not have count suffix in other method
names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
