[
https://issues.apache.org/jira/browse/HBASE-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408650#comment-13408650
]
Harsh J commented on HBASE-6350:
--------------------------------
{quote}-1 tests included. The patch doesn't appear to include any new or
modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.{quote}
I started an RS and did a remote FS bulk load call to verify some of the
logging changes.
bq. -1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
I don't see how this came to be. I've merely added a few already existing
objects here and there and changed a few string messages. I am not sure this
warning is cause of me.
bq. -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.
No, it does not. At least I don't see how the warnings apply to my changes.
bq. -1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.TestZooKeeper
This doesn't seem to be cause of my trivial patch either.
> Some logging improvements for RegionServer bulk loading
> -------------------------------------------------------
>
> Key: HBASE-6350
> URL: https://issues.apache.org/jira/browse/HBASE-6350
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: HBASE-6350.patch
>
>
> The current logging in the bulk loading RPC call to a RegionServer lacks some
> info in certain cases. For instance, I recently noticed that it is possible
> that IOException may be caused during bulk load file transfer (copy) off of
> another FS and that during the same time the client already times the socket
> out and thereby does not receive a thrown Exception back remotely (HBase
> prints a ClosedChannelException for the IPC when it attempts to send the real
> message, and hence the real cause is lost).
> Improvements around this kind of issue, wherein we could first log the
> IOException at the RS before sending, and a few other wording improvements
> are present in my patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
