bbeaudreault commented on PR #5099: URL: https://github.com/apache/hbase/pull/5099#issuecomment-1485219620
Thanks again nick! I agree it'd be nice if there were an OTS rate limiter we can use. That was my first thought here as well, since it took me a bit to really grok what was happening here. The most obvious candidate is guava, but unfortunately it doesn't really work with how we currently use rate limiters in quotas. As described above, we need sort of a multi-phase commit rate limiter where you can lease and return permits, check for permits without consuming, and consume non-blocking (after request is finished, when we finally know how much we needed). For this issue I'm partial to merging as is. I can give a quick search around for rate limiters like this and file a jira if any look promising. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
