NihalJain commented on PR #113: URL: https://github.com/apache/hbase-operator-tools/pull/113#issuecomment-1491858608
> @NihalJain @chrajeshbabu does this change break compatibility with versions < 2.5.3? If so, we should make it compatible with 2.4, at least. You can check HBCK2.checkHBCKSupport logic for an example on how to verify cluster version, so that depending on the version, we should use one regex or another. Hi @wchevreuil Thanks for having at look at this. As shown in the sample tests for regex below: - old regex: https://regex101.com/r/iJrOxD/1 - new regex: https://regex101.com/r/IKmASB/1 The new regex is an extension of old one, i.e. strings matching old regex, also match new regex. See samples in above links. So it would not break compatibility. Do you still want to to handle the based on versions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
