mwkang commented on code in PR #4720:
URL: https://github.com/apache/hbase/pull/4720#discussion_r1159195873
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java:
##########
@@ -255,11 +258,20 @@ static interface Engine {
* This is the default engine.
*/
static class JavaRegexEngine implements Engine {
+ private static final Configuration conf = HBaseConfiguration.create();
Review Comment:
@Apache9
I think it is possible.
`RSRpcService` pass configuration to `ProtobufUtil`.
https://github.com/apache/hbase/blob/f27823e62ddea58e827f68bb75289dbe13a1bd37/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L2456
->
```java
Get clientGet = ProtobufUtil.toGet(get, regionServer.conf);
```
`ProtobufUtil#toComparator` pass configuration to `ByteArrayComparable` when
calling parseFrom method.
https://github.com/apache/hbase/blob/f27823e62ddea58e827f68bb75289dbe13a1bd37/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L1559
->
```java
public static ByteArrayComparable toComparator(ComparatorProtos.Comparator
proto, Configuration conf) {
return (ByteArrayComparable)parseFrom.invoke(null, value, conf);
}
```
I'll try to make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
