bbeaudreault commented on code in PR #5155:
URL: https://github.com/apache/hbase/pull/5155#discussion_r1159765965
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/OnlineLogRecord.java:
##########
@@ -52,6 +59,15 @@ final public class OnlineLogRecord extends LogEntry {
if (slowLogPayload.getMultiServiceCalls() == 0) {
jsonObj.remove("multiServiceCalls");
}
+ if (slowLogPayload.getScan().isPresent()) {
+ try {
+ jsonObj.add("scan",
JsonParser.parseString(slowLogPayload.getScan().get().toJSON()));
Review Comment:
Rather than toJson, then parse, then back to json. What I'd you just use
toMap() here and let the local gson handle turning that into json?
I believe toJson just does toMap and then converts that to a json string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
