[
https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-27785:
-----------------------------
Description: {{ReplicationSourceManager.totalBufferUsed}} is a counter,
and is scoped to {{ReplicationSourceManager}}, but it is copied to
{{ReplicationSource}} and {{ReplicationSourceWALReader}}, which makes the logic
about {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout
{{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
and {{ReplicationSourceShipper}}. It causes duplicated code and would make
tracing the buffer usage somewhat difficult when there is problem about
{{totalBufferUsed}}. I think we should encapsulate and centralize it in
{{ReplicationSourceManager}}. (was:
{{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to
{{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and
{{ReplicationSourceWALReader}}, which makes the logic about
{{ReplicationSourceManager.totalBufferUsed}} is scattered throughout
{{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
and {{ReplicationSourceShipper}}, which cause duplicated code and would make
tracing the buffer usage somewhat difficult when there is problem about
{{totalBufferUsed}}. I think we should encapsulate and centralize it in
{{ReplicationSourceManager}}.)
> Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
> ----------------------------------------------------------------------
>
> Key: HBASE-27785
> URL: https://issues.apache.org/jira/browse/HBASE-27785
> Project: HBase
> Issue Type: Improvement
> Components: Replication
> Affects Versions: 3.0.0-alpha-3
> Reporter: chenglei
> Assignee: chenglei
> Priority: Major
>
> {{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to
> {{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and
> {{ReplicationSourceWALReader}}, which makes the logic about
> {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout
> {{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
> and {{ReplicationSourceShipper}}. It causes duplicated code and would make
> tracing the buffer usage somewhat difficult when there is problem about
> {{totalBufferUsed}}. I think we should encapsulate and centralize it in
> {{ReplicationSourceManager}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
