chrajeshbabu commented on code in PR #5170:
URL: https://github.com/apache/hbase/pull/5170#discussion_r1165920789
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java:
##########
@@ -474,6 +494,11 @@ private boolean isLargeEnoughForMerge(final
NormalizerConfiguration normalizerCo
return getRegionSizeMB(regionInfo) >=
normalizerConfiguration.getMergeMinRegionSizeMb(ctx);
}
+ private boolean isPresplitEmptyRegion(final NormalizerConfiguration
normalizerConfiguration,
+ final NormalizeContext ctx, final RegionInfo regionInfo) {
+ return getStoreFileCount(regionInfo) == 0 &&
Review Comment:
> Why getStoreFileCount == 0 means this is a pre split region?
Thanks for review @Apache9. When the region empty means there are three
scenarios 1) pre split region where there are no storefiles and region size is
0(in the normalization we are not considering memstore data or live updates so
considering store files count 0 as one of the option to detect presplit
region) 2) TTL expired for region then major compaction cleanup but create
zero size store files where count is more than 0 but region size is 0 3) All
the region data is deleted in this case also major compaction creates empty
store files but region size is 0.
Will clear other checkstyle and spotless checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
