bbeaudreault commented on code in PR #5171:
URL: https://github.com/apache/hbase/pull/5171#discussion_r1175853711
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java:
##########
@@ -448,6 +451,33 @@ public final int compareFamilies(Cell left, Cell right) {
right.getFamilyArray(), right.getFamilyOffset(),
right.getFamilyLength());
}
+ /**
+ * This method will be overridden when we compare cells inner store to
bypass family comparing.
+ */
+ protected int compareFamilies(KeyValue left, KeyValue right, int
leftFamilyLength,
Review Comment:
Can you use more similar signature to existing methods? I find this ordering
confusing, because everyone is used to doing left, leftOffset, leftLength,
right, rightOffset, rightLenght.
This goes for all the new methods.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -277,14 +277,6 @@ public class HRegion implements HeapSize,
PropagatingConfigurationObserver, Regi
public static final String RECOVERED_EDITS_IGNORE_EOF =
"hbase.hregion.recovered.edits.ignore.eof";
- /**
- * Whether to use {@link MetaCellComparator} even if we are not meta region.
Used when creating
- * master local region.
- */
- public static final String USE_META_CELL_COMPARATOR =
"hbase.region.use.meta.cell.comparator";
Review Comment:
Not a huge deal, but why move this constant in this PR? Doesn't seem related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
