[
https://issues.apache.org/jira/browse/HBASE-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409211#comment-13409211
]
Hadoop QA commented on HBASE-5145:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535624/HBASE-5145.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2350//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2350//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2350//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2350//console
This message is automatically generated.
> HMasterCommandLine's -minServers seems to be useless.
> -----------------------------------------------------
>
> Key: HBASE-5145
> URL: https://issues.apache.org/jira/browse/HBASE-5145
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-5145.patch
>
>
> HMasterCommandLine gets a number via -minServers opt. and sets it to a config
> param "hbase.regions.server.count.min".
> This config is not used anywhere else.
> Perhaps it wants to use "hbase.master.wait.on.regionservers.mintostart"
> instead?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
