[ 
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717600#comment-17717600
 ] 

Nick Dimiduk commented on HBASE-27762:
--------------------------------------

Updated all back port branch PRs with the addendum from master, or the local 
equivalent.

I considered dropping this change from branch-2.5 and branch-2.4 because we'll 
never be able to back port a log4j2 dependency upgrade to those branches (short 
of CVE remediation), which means it's unlikely that the fix for LOG4J2-3660 
will ever be available there. On the other hand, if someone is struggling to 
debug procedure execution on one of these branches (as I was), they'll 
appreciate at least having the code changes already deployed. I've posted a new 
addendum for just branch-2.5 and 2.4 that reverts the pattern layout changes 
entirely for those branches -- we don't want the extra character noise in our 
test logs forevermore.

If for some reason LOG4J2-3660 does make it back to branch-2.4,5, we can 
re-apply the patternlayout change in test as it suits us.

> Include EventType and ProcedureV2 pid in logging via MDC
> --------------------------------------------------------
>
>                 Key: HBASE-27762
>                 URL: https://issues.apache.org/jira/browse/HBASE-27762
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Major
>             Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution 
> is painful. We are pretty good about logging the {{proc_id}} most of the 
> time, but we don't catch them all. Now that we're up on log4j2, let's use the 
> MDC feature to include some basic information universally.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to