Apache9 commented on code in PR #5171: URL: https://github.com/apache/hbase/pull/5171#discussion_r1180500794
########## hbase-common/src/main/java/org/apache/hadoop/hbase/InnerStoreCellComparator.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.yetus.audience.InterfaceStability; + +/** + * Compare two HBase cells inner store, skip compare family for better performance. Important!!! we + * should not make fake cell with fake family which length greater than zero inner store, otherwise + * this optimization cannot be used. + */ +@InterfaceAudience.Private +@InterfaceStability.Evolving +public class InnerStoreCellComparator extends CellComparatorImpl { + + private static final long serialVersionUID = 8186411895799094989L; + + public static final InnerStoreCellComparator INNER_STORE_COMPARATOR = + new InnerStoreCellComparator(); + + @Override + protected int compareFamilies(Cell left, int leftFamilyLength, Cell right, + int rightFamilyLength) { + return leftFamilyLength - rightFamilyLength; + } + + @Override + protected int compareFamilies(KeyValue left, int leftFamilyPosition, int leftFamilyLength, + KeyValue right, int rightFamilyPosition, int rightFamilyLength) { + return leftFamilyLength - rightFamilyLength; + } + + @Override + protected int compareFamilies(ByteBufferKeyValue left, int leftFamilyPosition, + int leftFamilyLength, ByteBufferKeyValue right, int rightFamilyPosition, + int rightFamilyLength) { + return leftFamilyLength - rightFamilyLength; + } + + @Override + protected int compareFamilies(KeyValue left, int leftFamilyPosition, int leftFamilyLength, + ByteBufferKeyValue right, int rightFamilyPosition, int rightFamilyLength) { + return leftFamilyLength - rightFamilyLength; + } + + /** + * Utility method that makes a guess at comparator to use based off passed tableName. Use in + * extreme when no comparator specified. + * @return CellComparator to use going off the {@code tableName} passed. + */ + public static CellComparator getInnerStoreCellComparator(Configuration conf, + TableName tableName) { + return getInnerStoreCellComparator(conf, tableName.toBytes()); + } + + /** + * Utility method that makes a guess at comparator to use based off passed tableName. Use in + * extreme when no comparator specified. + * @return CellComparator to use going off the {@code tableName} passed. + */ + public static CellComparator getInnerStoreCellComparator(byte[] tableName) { + return getInnerStoreCellComparator(null, tableName); + } + + public static CellComparator getInnerStoreCellComparator(Configuration conf, byte[] tableName) { + if ( + conf != null && conf.getBoolean(HConstants.USE_META_CELL_COMPARATOR, Review Comment: Can we move this judgement in upper layer so we do not need to move USE_META_CELL_COMPARATOR to HConstants? It is just for internal use, we'd better not put it into an IA.Public class... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
