[GitHub] [hbase] bsglz commented on a diff in pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store

[via GitHub]

bsglz commented on code in PR #5171:
URL: https://github.com/apache/hbase/pull/5171#discussion_r1182008415


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java:
##########
@@ -121,7 +122,8 @@ public class FixedFileTrailer {
    * Raw key comparator class name in version 3
    */
   // We could write the actual class name from 2.0 onwards and handle BC
-  private String comparatorClassName = 
CellComparator.getInstance().getClass().getName();
+  private String comparatorClassName =

Review Comment:
   > No compatibility issues?
   
   Thought about it and i think so, because we do the conversion when we save 
and read the hfile, the actual store is the KVComparator, we can't change this 
since we want hbase1.x to be able to read the files generated in the new 
version.
   Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org