[ 
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409552#comment-13409552
 ] 

nkeywal commented on HBASE-6356:
--------------------------------

Yes, we're not allowed to throw. I wonder if it's better to log.warn or to stop 
here. Today when it happens it returns false, so the easy option is to just log 
and saying that we keep the backward compatibility this way...
                
> printStackTrace in FSUtils
> --------------------------
>
>                 Key: HBASE-6356
>                 URL: https://issues.apache.org/jira/browse/HBASE-6356
>             Project: HBase
>          Issue Type: Bug
>          Components: client, master, regionserver
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Priority: Trivial
>              Labels: noob
>
> This is bad...
> {noformat}
>     public boolean accept(Path p) {
>       boolean isValid = false;
>       try {
>         if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
>           isValid = false;
>         } else {
>             isValid = this.fs.getFileStatus(p).isDir();
>         }
>       } catch (IOException e) {
>         e.printStackTrace();          <================ 
>       }
>       return isValid;
>     }
>   }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to