[
https://issues.apache.org/jira/browse/HBASE-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409953#comment-13409953
]
Jean-Daniel Cryans commented on HBASE-6323:
-------------------------------------------
I did a review with Elliott, basically there's 3 "Copyright 2010" to remove and
ReplicationMetricsSource needs some refactoring because right now there's 3
methods that are almost identical.
> [replication] most of the source metrics are wrong when there's multiple
> slaves
> -------------------------------------------------------------------------------
>
> Key: HBASE-6323
> URL: https://issues.apache.org/jira/browse/HBASE-6323
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6323-0.patch, HBASE-6323-1.patch
>
>
> Most of the metrics in replication were written with 1 slave in mind but with
> multiple slaves the issue really shows. Most of the metrics are set directly:
> {code}
> public void enqueueLog(Path log) {
> this.queue.put(log);
> this.metrics.sizeOfLogQueue.set(queue.size());
> }
> {code}
> So {{sizeOfLogQueue}} is always showing the size of the queue that updated
> the metric last.
> I'm not sure what's the right way to fix this since we can't have dynamic
> metrics. Merging them would work here but it wouldn't work so well with
> {{ageOfLastShippedOp}} since the age can be different and it definitely
> cannot be summed.
> Assigning to Elliott since he seems to dig metrics these days.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
