zhuyaogai commented on code in PR #5224:
URL: https://github.com/apache/hbase/pull/5224#discussion_r1199909307


##########
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestMetricsConnection.java:
##########
@@ -178,7 +178,8 @@ public void testStaticMetrics() throws IOException {
         MutateRequest.newBuilder()
           .setMutation(ProtobufUtil.toMutation(MutationType.PUT, new 
Put(foo))).setRegion(region)
           .build(),
-        MetricsConnection.newCallStats(), null);
+        MetricsConnection.newCallStats(),
+        new CallTimeoutException("test with CallTimeoutException"));

Review Comment:
   Since I need to test the code I modified, I randomly  select a mutation type 
to throw the exception (such as `Put`), and the metric key may be like 
`rpcFailureCount_ClientService_Mutate(Put)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to