Apache9 commented on code in PR #5252:
URL: https://github.com/apache/hbase/pull/5252#discussion_r1204149381
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java:
##########
@@ -266,14 +267,16 @@ public Path getCurrentPath() {
return logQueue.getQueue(walGroupId).peek();
}
- // returns false if we've already exceeded the global quota
- private boolean checkBufferQuota() {
+ // sleeping when we've already exceeded the global quota
+ private void checkBufferQuota() {
// try not to go over total quota
- if (!this.getSourceManager().checkBufferQuota(this.source.getPeerId())) {
- Threads.sleep(sleepForRetries);
- return false;
+ while (
Review Comment:
Why we need to change the code like this? I think change the
sleepForRetriesin this method to sleepForQuotaCheck is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
