[
https://issues.apache.org/jira/browse/HBASE-27903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728795#comment-17728795
]
Duo Zhang commented on HBASE-27903:
-----------------------------------
Anyway, you can not remove the preChecks in the procedures. We have table locks
when executing table/region related procedures, so we can make sure there are
not data races when checking the flag in these procedures. Checking the flag
before submitting can be an improvement since it could fail earlier, but better
add some comments to mention that this is not enough, we will need the checks
in split/merge procedures.
> Skip submitting Split/Merge procedure when split/merge is disabled at table
> level
> ---------------------------------------------------------------------------------
>
> Key: HBASE-27903
> URL: https://issues.apache.org/jira/browse/HBASE-27903
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Reporter: Ashok shetty
> Assignee: Nihal Jain
> Priority: Minor
>
> *Scenario*
> If split/merge is disabled at table level , master will submit a
> SplitTableRegionProcedure/MergeTableRegionsProcedure , and rollback it as
> execution fails during pre-checks .
> *Improvement*
> Master can check it early and no need to submit
> SplitTableRegionProcedure/MergeTableRegionsProcedure when split/merge switch
> is disabled at Table level.
> *Steps*
> {code:java}
> create 'testCreateTableWithMergeDisableParameter', 'f1', {MERGE_ENABLED =>
> false}
> list_regions 'testCreateTableWithMergeDisableParameter'
> merge_region
> 'd21cdc5d488e8036017696c46cffd9b1','6382c8f731a4f0379b6e98ece4b06e3e'
> {code}
> {code:java}
> create 'testcreatetablewithsplitdisableparameter', 'f1', {SPLIT_ENABLED =>
> false}
> split 'testcreatetablewithsplitdisableparameter','30'{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
