Apache9 commented on code in PR #5255:
URL: https://github.com/apache/hbase/pull/5255#discussion_r1215534043
##########
hbase-common/src/main/resources/hbase-default.xml:
##########
@@ -2062,4 +2062,9 @@ possible configurations would overwhelm and obscure the
important.
hitting the namenode, if the DFSInputStream's block list is incomplete.
</description>
</property>
+ <property>
+ <name>hbase.fs.reader.warn.time</name>
+ <value>100</value>
Review Comment:
Is 100ms a good default value? Maybe we should set it to 0 or -1, means
disable the logging, and if users want, they can set it to the value they want?
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java:
##########
@@ -1603,6 +1603,13 @@ public enum OperationStatusCode {
*/
public final static boolean HBASE_SERVER_USEIP_ENABLED_DEFAULT = false;
+ /**
+ * If reading block cost time more than the threshold, a warning will be
logged.
+ */
+ public static final String FS_READER_WARN_TIME = "hbase.fs.reader.warn.time";
Review Comment:
Better add this somewhere in the hbase-server module?
##########
hbase-common/src/main/resources/hbase-default.xml:
##########
@@ -2062,4 +2062,9 @@ possible configurations would overwhelm and obscure the
important.
hitting the namenode, if the DFSInputStream's block list is incomplete.
</description>
</property>
+ <property>
+ <name>hbase.fs.reader.warn.time</name>
Review Comment:
Better add a '.ms' suffix so users know it is in milliseconds, without
reading the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
