bbeaudreault commented on code in PR #5257: URL: https://github.com/apache/hbase/pull/5257#discussion_r1218639641
########## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnectionSnapshot.java: ########## Review Comment: I'm also wondering if we want to try to avoid exposing the codahale metrics Snapshot directly? It might make compatibility tricky in the future, if the upstream api there changes? Just a thought -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
