virajjasani commented on PR #5266: URL: https://github.com/apache/hbase/pull/5266#issuecomment-1582924617
@Apache9 i understand your point, maybe we can update existing method and use List<ServerName> instead of single ServerName and that is more flexible as client can pass single server as well, correct? but since we already have that method since 2.0, we will have to go through deprecation cycle (maybe we still can). However given that FutureUtils have bunch of nice utilities worth using by methods like this one, and it is IA.Private, it would be nice to have it in hbase IMHO than let client use CompletableFuture callbacks/whenCompleted etc. better to let the client only worry about using `future#get-with-timeout` since other APIs are nicely used within FutureUtils anyways. if you are fine, i can now start reviewing. please let me know. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
