comnetwork commented on code in PR #5281:
URL: https://github.com/apache/hbase/pull/5281#discussion_r1225251675
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerResponseEncoder.java:
##########
@@ -31,6 +31,8 @@
@InterfaceAudience.Private
class NettyRpcServerResponseEncoder extends ChannelOutboundHandlerAdapter {
+ static final String HANDLER_NAME = "NettyRpcServerResponseEncoder";
Review Comment:
@wchevreuil, thanks for review，here I did not name it as "ENCODER_NAME"
because it is misleading and is also inconsistent with the naming conventions
of other netty handlers, here this name represents
`NettyRpcServerResponseEncoder` itself，but for other netty handler such as
`NettyRpcServerPreambleHandle`,`NettyRpcServerPreambleHandler.DECODER_NAME`
represents decoder handler before it, not represents itself. I have ready
renamed it as "NAME" to keep consistent with the naming conventions of other
netty handlers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
