Apache9 commented on PR #4721:
URL: https://github.com/apache/hbase/pull/4721#issuecomment-1594875816

   @comnetwork Do you still have interest in implementing this?
   
   WHen investigating how to better support sync replication in WAL framework, 
as well as how could we introduce new WAL implementations, I believe a better 
way is to also make sync replication work with FSHLog, and also, the new WAL 
implementation should try to implement AsyncWriter or Writer interface, if they 
choose any support Writer interface(this is possible if they only implement the 
hadoop fs APIs), then the new WAL implementation can only work FSHLog, so I 
think we still need FSHLog in the future.
   
   So now I'm OK without touching the code in FSHLog and also in AsyncFSWAL to 
make them share more code and use similiar mechanism to deal with errors. Let's 
revive this PR.
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to