bbeaudreault commented on code in PR #5293:
URL: https://github.com/apache/hbase/pull/5293#discussion_r1232544851
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java:
##########
@@ -317,12 +317,15 @@ private void tune() {
unblockedFlushCnt = unblockedFlushCount.getAndSet(0);
tunerContext.setUnblockedFlushCount(unblockedFlushCnt);
metricsHeapMemoryManager.updateUnblockedFlushCount(unblockedFlushCnt);
- // TODO : add support for offheap metrics
tunerContext.setCurBlockCacheUsed((float) blockCache.getCurrentSize() /
maxHeapSize);
metricsHeapMemoryManager.setCurBlockCacheSizeGauge(blockCache.getCurrentSize());
+ long globalMemstoreDataSize =
regionServerAccounting.getGlobalMemStoreDataSize();
long globalMemstoreHeapSize =
regionServerAccounting.getGlobalMemStoreHeapSize();
+ long globalMemStoreOffHeapSize =
regionServerAccounting.getGlobalMemStoreOffHeapSize();
tunerContext.setCurMemStoreUsed((float) globalMemstoreHeapSize /
maxHeapSize);
- metricsHeapMemoryManager.setCurMemStoreSizeGauge(globalMemstoreHeapSize);
Review Comment:
Ah interesting.
So I wasn't talking about these metrics at all. These metrics show up in JMX
under `sub=Memory` (which for us is all 0's for some reason, and we don't use
them).
The metrics I was referring to are in `sub=Server` and also per-region and
per-table metrics. These also have a `memStoreSize` field, and it is derived
from the DataSize rather than HeapSize. These are calculated in a few places,
you have to sort of dig in based on usages of
`MetricsRegionServerSource.MEMSTORE_SIZE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
