[ 
https://issues.apache.org/jira/browse/HBASE-27940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733948#comment-17733948
 ] 

Hudson commented on HBASE-27940:
--------------------------------

Results for branch branch-2.5
        [build #370 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/370/]:
 (/) *{color:green}+1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/370/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/370/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/370/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/370/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Midkey metadata in root index block would always be ignored by 
> BlockIndexReader.readMultiLevelIndexRoot
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-27940
>                 URL: https://issues.apache.org/jira/browse/HBASE-27940
>             Project: HBase
>          Issue Type: Bug
>          Components: HFile
>    Affects Versions: 3.0.0-alpha-4, 2.4.17, 2.5.5, 4.0.0-alpha-1
>            Reporter: chenglei
>            Assignee: chenglei
>            Priority: Major
>             Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> After HBASE-27053, checksum is removed from the {{HFileBlock}} {{ByteBuff}}  
> in {{FSReaderImpl.readBlockDataInternal}}  once the checksum is verified, so 
> {{HFileBlock.buf}} does not include checksum, but for 
> {{BlockIndexReader.readMultiLevelIndexRoot}}, after read root index entries , 
> it still subtracts the checksum to check if the midkey metadat exists,  the 
> midkey metadata would always be ignored: 
> {code:java}
> public void readMultiLevelIndexRoot(HFileBlock blk, final int numEntries) 
> throws IOException {
>       DataInputStream in = readRootIndex(blk, numEntries);
>       // after reading the root index the checksum bytes have to
>       // be subtracted to know if the mid key exists.
>       int checkSumBytes = blk.totalChecksumBytes();
>       if ((in.available() - checkSumBytes) < MID_KEY_METADATA_SIZE) {
>         // No mid-key metadata available.
>         return;
>       }
>       midLeafBlockOffset = in.readLong();
>       midLeafBlockOnDiskSize = in.readInt();
>       midKeyEntry = in.readInt();
>  }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to