guluo2016 commented on PR #5273: URL: https://github.com/apache/hbase/pull/5273#issuecomment-1598961060
> > > > Is this a bug, or are we actually skipping compaction later on? > > > > > > It is not a bug and would skip compaction later. see code in here: [Skipping compaction if we donot need it](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1654-L1672) > > In here, I mean we only skip early before we foreach `region.stores` if the table disable compaction. > > Thanks for explaining it. Makes sense to me, approved this, just had a suggestion to "reword" the comment. Thanks for your comments, I will update later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
