rmdmattingly commented on code in PR #5275:
URL: https://github.com/apache/hbase/pull/5275#discussion_r1237204898
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBatchRpcRetryingCaller.java:
##########
@@ -465,27 +465,40 @@ private void onError(Map<byte[], RegionRequest>
actionsByRegion, int tries, Thro
List<Action> copiedActions = actionsByRegion.values().stream().flatMap(r
-> r.actions.stream())
.collect(Collectors.toList());
addError(copiedActions, error, serverName);
- tryResubmit(copiedActions.stream(), tries, error instanceof
RetryImmediatelyException,
- HBaseServerException.isServerOverloaded(error));
+ tryResubmit(copiedActions.stream(), tries, error instanceof
RetryImmediatelyException, error);
}
private void tryResubmit(Stream<Action> actions, int tries, boolean
immediately,
- boolean isServerOverloaded) {
+ Throwable error) {
if (immediately) {
groupAndSend(actions, tries);
return;
}
+
+ boolean isServerOverloaded =
HBaseServerException.isServerOverloaded(error);
Review Comment:
I believe this logic is covered by existing tests in
`TestAsyncClientPauseForServerOverloaded`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
