virajjasani commented on code in PR #5308: URL: https://github.com/apache/hbase/pull/5308#discussion_r1239120005
########## hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java: ########## @@ -238,6 +238,10 @@ public interface MetricsRegionServerSource extends BaseSource, JvmPauseMonitorSo String MAX_COMPACTED_STORE_FILE_REF_COUNT = "maxCompactedStoreFileRefCount"; String MEMSTORE_SIZE = "memStoreSize"; String MEMSTORE_SIZE_DESC = "Size of the memstore"; + String MEMSTORE_ONHEAP_SIZE = "memStoreOnHeapSize"; Review Comment: let's keep `memStoreHeapSize` as Duo suggested and it is also referenced as memStoreHeapSize at multiple places? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
