jinggou commented on code in PR #5293:
URL: https://github.com/apache/hbase/pull/5293#discussion_r1239117258
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java:
##########
@@ -317,12 +317,15 @@ private void tune() {
unblockedFlushCnt = unblockedFlushCount.getAndSet(0);
tunerContext.setUnblockedFlushCount(unblockedFlushCnt);
metricsHeapMemoryManager.updateUnblockedFlushCount(unblockedFlushCnt);
- // TODO : add support for offheap metrics
tunerContext.setCurBlockCacheUsed((float) blockCache.getCurrentSize() /
maxHeapSize);
metricsHeapMemoryManager.setCurBlockCacheSizeGauge(blockCache.getCurrentSize());
+ long globalMemstoreDataSize =
regionServerAccounting.getGlobalMemStoreDataSize();
long globalMemstoreHeapSize =
regionServerAccounting.getGlobalMemStoreHeapSize();
+ long globalMemStoreOffHeapSize =
regionServerAccounting.getGlobalMemStoreOffHeapSize();
tunerContext.setCurMemStoreUsed((float) globalMemstoreHeapSize /
maxHeapSize);
- metricsHeapMemoryManager.setCurMemStoreSizeGauge(globalMemstoreHeapSize);
Review Comment:
@bbeaudreault Sorry I didn't realize that you are referring to `sub=Server`.
This change is made for `sub=Memory`, so I create a new pr
(https://github.com/apache/hbase/pull/5308) for HBASE-27892.
For the code change here, I think it might be a bug because memStoreSize
should refer to memstore data size instead of memstore heap size, and also
noticed that its value is 0 under `sub=Memory` (while not 0 under
`sub=Server`). Need to do some digging to see if it is a bug.. I've created a
new jira HBASE-27948 to figure out this issue. @Apache9 @virajjasani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
