[
https://issues.apache.org/jira/browse/HBASE-27954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739631#comment-17739631
]
chenglei commented on HBASE-27954:
----------------------------------
PUshed to 2.6+, thanks [~zhangduo] for reviewing!
> Eliminate duplicate code for getNonRootIndexedKey in HFileBlockIndex
> ---------------------------------------------------------------------
>
> Key: HBASE-27954
> URL: https://issues.apache.org/jira/browse/HBASE-27954
> Project: HBase
> Issue Type: Improvement
> Components: HFile
> Affects Versions: 3.0.0-alpha-4, 4.0.0-alpha-1
> Reporter: chenglei
> Assignee: chenglei
> Priority: Major
>
> The code to get the {{midkey}} by {{midLeafBlock}} in
> {{HFileBlockIndex.CellBasedKeyBlockIndexReader.midkey}} method is almost the
> same as {{HFileBlockIndex.BlockIndexReader.getNonRootIndexedKey}}, the code
> is somewhat complicated, we could use the
> {{HFileBlockIndex.BlockIndexReader.getNonRootIndexedKey}} directly in
> {{HFileBlockIndex.CellBasedKeyBlockIndexReader.midkey}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
