bbeaudreault commented on PR #5288: URL: https://github.com/apache/hbase/pull/5288#issuecomment-1621957983
Yea so we are talking about RSRpcServices.replicateWALEntry endpoint, correct? The NettyRpcServerResponseEncoder calls `done()` after the response bytes are written to the channel (i.e. from `ServerCall.sendResponseIfReady()`). The response bytes in this case is an empty ReplicateWALEntryResponse proto. The `replicateWALEntry` method should only return a ReplicateWALEntryResponse once the batch calls have all succeeded or failed. So we should only trigger NettyRpcServerResponseEncoder once the batch calls have all succeeded or failed. So I'm not sure why this would cause a problem for retries within replicateWALEntry? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
