frostruan commented on code in PR #5319:
URL: https://github.com/apache/hbase/pull/5319#discussion_r1258168483
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java:
##########
@@ -121,6 +122,8 @@ public class AsyncConnectionImpl implements AsyncConnection
{
private final String metricsScope;
private final Optional<MetricsConnection> metrics;
+ private JvmPauseMonitor pauseMonitor;
Review Comment:
Good idea ! But if so, we may need to consider adding a reference count to
pauseMonitor. Only when all connections that refer to it are no longer active,
we can stop it . Or we can keep it all the time , even all the connections are
closed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
