comnetwork commented on code in PR #5317:
URL: https://github.com/apache/hbase/pull/5317#discussion_r1259145211
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##########
@@ -414,6 +485,23 @@ protected final int getPreallocatedEventCount() {
return floor << 1;
}
+ protected void setWaitOnShutdownInSeconds(int waitOnShutdownInSeconds,
Review Comment:
@Apache9 , thank you very much for rebase, LGTM, just a little problem,
may be we could declare this method as final because it is called by ctor ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
