[ 
https://issues.apache.org/jira/browse/HBASE-27996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748247#comment-17748247
 ] 

Andrew Kyle Purtell edited comment on HBASE-27996 at 7/27/23 4:21 PM:
----------------------------------------------------------------------

bq. I don't think it was a conscious decision to keep this.

I can see a line of thought that considers since HTable implements the stable 
Table interface, so is going to inherit the parent interface's stability in 
that sense, enough to leave the annotation, but that does not make much sense 
to me, because HTable can gain or lose public-but-internal methods at any time. 

What I would suggest is look at the recent history of changes to HTable, and/or 
upcoming proposed changes, and decide if that annotation still reflects 
reality. 

I would remove it.


was (Author: apurtell):
bq. I don't think it was a conscious decision to keep this.

I can see a line of thought that considers since HTable implements the stable 
Table interface, so is going to inherit the parent interface's stability in 
that sense, enough to leave the annotation, but that does not make much sense 
to me, because HTable can gain or lose public-but-internal methods at any time. 

What I would suggest is look at the recent history of changes to HTable, and/or 
upcoming proposed changes, and decide if that annotation still reflects 
reality. 

> Remove InterfaceStability.Stable from HTable
> --------------------------------------------
>
>                 Key: HBASE-27996
>                 URL: https://issues.apache.org/jira/browse/HBASE-27996
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Bryan Beaudreault
>            Priority: Major
>
> HTable is InterfaceAudience.Private, but the InterfaceStability.Stable 
> annotation was not removed when that was changed. Based on our compatibility 
> guidelines, IS.Stable only applies to IA.Public classes. This annotation is 
> confusing to new developers who might work on modifying HTable
> Reference: https://hbase.apache.org/book.html#_interface_classifications



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to