[
https://issues.apache.org/jira/browse/HBASE-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411902#comment-13411902
]
Marcelo Vanzin commented on HBASE-6373:
---------------------------------------
I'm not dereferencing remoteAddr; it's safe to have a null reference in the
middle of string concatenation. In fact that did show up during my testing (you
just get "null" in the log message).
Unless you prefer to log an empty string instead of "null" in that case.
> Add more context information to audit log messages
> --------------------------------------------------
>
> Key: HBASE-6373
> URL: https://issues.apache.org/jira/browse/HBASE-6373
> Project: HBase
> Issue Type: Improvement
> Components: security
> Reporter: Marcelo Vanzin
> Priority: Minor
> Attachments: accesscontroller.patch
>
>
> The attached patch adds more information to the audit log messages; namely,
> it includes the IP address where the request originated, if it's available.
> The patch is against trunk, but I've tested it against the 0.92 branch. I
> didn't find any unit test for this code, please let me know if I missed
> something.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira