Reidddddd commented on code in PR #5323:
URL: https://github.com/apache/hbase/pull/5323#discussion_r1281492205
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/MetricsIO.java:
##########
@@ -24,10 +24,12 @@
@InterfaceAudience.Private
public class MetricsIO {
+ private static volatile MetricsIO instance;
private final MetricsIOSource source;
private final MetricsIOWrapper wrapper;
- public MetricsIO(MetricsIOWrapper wrapper) {
+ // visible for testing only
+ MetricsIO(MetricsIOWrapper wrapper) {
Review Comment:
weird here, here is implementing a singleton, but there is still a public
constructor...
is it used somewhere? if not, could we just delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
